search

tanmaykm / Thrift.jl

Thrift for Julia
Other
27 stars 14 forks source link

HTTP Transport #49

Open tanmaykm opened 5 years ago

tanmaykm commented 5 years ago

It will be good to have an implementation of HTTP transport.

ref: https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/THttpClient.cpp and https://people.apache.org/~thejas/thrift-0.9/javadoc/org/apache/thrift/transport/THttpClient.html

randyzwitch commented 5 years ago

Was just about to come by to ask about HTTP/HTTPS support. Unfortunately, I don't know C++, but I'm absolutely willing to help out by testing or whatever else as Thrift.jl is the cornerstone of OmniSci.jl

randyzwitch commented 5 years ago

At least in our case, this also requires TJSONProtocol to be implemented. Do you have an idea of which might be simpler to tackle? I've been getting better at C++, so I can probably read the Thrift code and translate to Julia with a bit of guidance

tanmaykm commented 5 years ago

The JSON protocol appears somewhat simpler to me. Happy to help along with whatever I can!