search

tanmaykm / Thrift.jl

Thrift for Julia
Other
27 stars 14 forks source link

write fixes (threads), add missing isfilled vector #68

Closed tanmaykm closed 3 years ago

tanmaykm commented 3 years ago
codecov-commenter commented 3 years ago

Codecov Report

Merging #68 (544e900) into master (88f448c) will increase coverage by 9.24%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   49.06%   58.30%   +9.24%     
==========================================
  Files           8        8              
  Lines         964      969       +5     
==========================================
+ Hits          473      565      +92     
+ Misses        491      404      -87
Impacted Files Coverage Δ
src/base.jl 64.04% <50.00%> (+0.11%) :arrow_up:
src/codec.jl 100.00% <100.00%> (ø)
src/protocols.jl 61.66% <0.00%> (+29.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88f448c...544e900. Read the comment docs.

tdunning commented 3 years ago

This looks like it covers the issue we turned up in Parquet.jl.

I don't know the code base but these definitely all look pretty much like improvements to my outsider's eye.

Nice work!