search

tanmaykm / Thrift.jl

Thrift for Julia
Other
27 stars 14 forks source link

prevent method overwrite error at precompilation #71

Closed tanmaykm closed 2 years ago

tanmaykm commented 2 years ago

The readVarint signature with default argument was causing a method overwrite warning during precompilation.

[ Info: Precompiling Thrift [8d9c9c80-f77e-5080-9541-c6f69d204e22]
WARNING: Method definition readVarint(IO) where {S<:Integer} in module Thrift at /home/tan/.julia/dev/Thrift/src/utils.jl:68 overwritten at /home/tan/.julia/dev/Thrift/src/utils.jl:69.
  ** incremental compilation may be fatally broken for this module **

Removing the default value to prevent it.

ref: #70

cc: @tk3369

tk3369 commented 2 years ago

LGTM.

Ah, looks like it's a problem with Julia v1.3... I have been developing on 1.7 for the most part now :-)