search

tanmaykm / Thrift.jl

Thrift for Julia
Other
27 stars 14 forks source link

fix read function signatures #72

Closed tanmaykm closed 2 years ago

tanmaykm commented 2 years ago

Fix bug where certain read functions were taking UInt8 as second argument. This separates out the signatures that need Type from those that need number of bytes.

fixes: #69

cc: @tk3369

codecov-commenter commented 2 years ago

Codecov Report

Merging #72 (fb5b83b) into master (b449432) will decrease coverage by 0.32%. The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   64.42%   64.09%   -0.33%     
==========================================
  Files           9        9              
  Lines        1276     1284       +8     
==========================================
+ Hits          822      823       +1     
- Misses        454      461       +7
Impacted Files Coverage Δ
src/transports.jl 69.88% <23.07%> (-1.30%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b449432...fb5b83b. Read the comment docs.