pop-over: repository name illegible in dark mode

[shinenelson]

the name of the repository is illegible in dark mode

My guess is that because the following code unsets color for data-color-mode=dark https://github.com/tanmayrajani/notifications-preview-github/blob/8e07a8c2ad142b346406b3c2d7d49d4abaa9669a/extension/github-notifications-preview.css#L10-L12

GitHub's .text-inherit probably cannot inherit a color since it was unset earlier. Removing the class from the anchor node falls back to the default blue anchor color from GitHub's base.scss ( which is also okay in my humble opinion ).

PS : I can create a pull request if pointed in the right direction

[tanmayrajani]

could you please try to update your extension and see if that solves the problem? I see it correctly so

[shinenelson]

I believe I am on the latest release (which introduced dark mode support)

To avoid the possibility of cache, I signed in from Private Browsing and found the issue to still exist. To avoid the possibility of other extensions clashing with this one, I also created a fresh profile and installed this extension as the only extension in the profile. The issue still existed.

Also, the action buttons do not look as in your screenshot for me either. It looks like the screenshot in #116 (as if the extension was not updated at all).

For what it is worth, this is on Firefox. I extracted the extension package (xpi) and found the CSS files are similar in terms of content ( though not identical due to indentation differences ). I could not compare the javascript file because it was transpiled from JSX.