tanmayrajani / notifications-preview-github

Browser Extension: preview GitHub notifications with same page pop-overs
https://chrome.google.com/webstore/detail/github-notifications-prev/kgilejfahkjidpaclkepbdoeioeohfmj?hl=en&gl=IN
MIT License
141 stars 15 forks source link

Add option the popup to close on mouseleave #125

Open darkred opened 3 years ago

darkred commented 3 years ago

Closes #123

Test URLs

https://github.com/

Screenshot

2021-05-05_225054


Note to reviewers

I use .removeAttribute('open') to close the dropdown.

fregante commented 3 years ago

Thank you! I’ll make sure it works correctly soon

darkred commented 3 years ago

I made a change so that the popup close gets canceled if you re-mousenter quick enough, within 1 sec (1000 ms) (and updated the screenshot in the OP).

darkred commented 3 years ago

Hi @fregante Is there any way I can assist you in making the PR complete ?

  Some notes:

darkred commented 2 years ago

Thank you! I’ll make sure it works correctly soon

@fregante Have you changed your mind? Do you find this PR is not salvageable? Should I close this?

fregante commented 2 years ago

I've been on Safari for a year and I haven't used some of my extensions since 😅 so you can just leave this open until someone reviews it