Finish transition to new Notifications

[fregante]

81 added support for the new Notifications in the least intrusive way possible, but the CSS is almost entirely outdated and the JS still has some references to DOM that no longer exists.

• [ ] Fix mark as read: https://github.com/tanmayrajani/notifications-preview-github/issues/93
• [x] Improve style
• [x] Drop unused CSS
• [x] Fix non-Compact view (currently unsupported)
• [x] Drop outdated JS

57 could be considered

[darkred]

I've noticed the following with the new version, regarding the #57 feature: ^{and thought to post it here, instead of opening a new issue}

(Tested extension 20.4.5 in a fresh Chrome 81 profile) if I enable Show only participating notifications then the notification number in the bubble is no longer displayed, even if Show notification number in blue bubble remains enabled.

Screenshot comparison having Show only participating notifications :

Disabled --> bubble number is ok


Enabled --> bubble number is missing


[fregante]

Please open a new issue if it's still broken. I'll mark this as done due to https://github.com/tanmayrajani/notifications-preview-github/releases/tag/20.4.22

[fregante]

If you enable GitHub’s "Group by repository" option, the extension now exactly looks like it used to 🎉

While the new style is this, cleaned up:

[darkred]

Please open a new issue if it's still broken. I'll mark this as done due to 20.4.22 (release)

I see that the new version, 20.4.22, is available only in Firefox AMO. In CWS it's still 20.4.5. Maybe it's stuck at pending review ?

And, I've tested the Firefox version, and the counter in the bubble is still broken if I enable Show only participating notifications. Is it ok if I open a new issue based only on the Firefox version?

[fregante]

This is due to #91

[darkred]

Thanks for the info. The review procedure in CWS is still so awful for the developers..

[fregante]

They started requesting more information lately, so every old extension is stuck until we add the information. It happened to my other 3 extensions I updated recently.

[darkred]

Thank you for the quick response. I'm glad the new version is now in CWS as well.

I opened a new issue here: https://github.com/tanmayrajani/notifications-preview-github/issues/95