tanmayrajani / notifications-preview-github

Browser Extension: preview GitHub notifications with same page pop-overs
https://chrome.google.com/webstore/detail/github-notifications-prev/kgilejfahkjidpaclkepbdoeioeohfmj?hl=en&gl=IN
MIT License
141 stars 15 forks source link

Chrome Store rejected new versions (privacy info) #91

Closed fregante closed 4 years ago

fregante commented 4 years ago

Publish condition not met: To publish your item, you must provide mandatory privacy information. This can be done in the new Developer Dashboard: https://chrome.google.com/webstore/devconsole.

Related Refined GitHub issue, probably parts of it can be copied: https://github.com/sindresorhus/refined-github/issues/2685

@tanmayrajani can you look into it?

tanmayrajani commented 4 years ago

image

I'm guessing since we use npm modules, we are using remote code?

What should the justification be for that?

fregante commented 4 years ago

No we’re not using remote code 😃 The code is packaged and sent to them in a zip file. By “remote” they mean “downloaded from the internet directly from the user’s computer”

tanmayrajani commented 4 years ago

oh right, makes sense :man_facepalming:. I have just submitted the request. It's in pending review now.

tanmayrajani commented 4 years ago

It's published! :clinking_glasses:

fregante commented 4 years ago

That was fast!

fregante commented 4 years ago

@tanmayrajani are you sure? It still says this when I try to submit it again:

Publish condition not met: To publish your item, you must provide mandatory privacy information in the new Developer

tanmayrajani commented 4 years ago

It's asking justification for storage.. weird that a few days ago that wasn't a field in the form, must be some new changes. Anyway, I'm mentioning that we need it for storing user preferences. Let me know in case of changes..

fregante commented 4 years ago

Heh, it's possible. Yes we use storage for the options

tanmayrajani commented 4 years ago

It got updated on the chrome store too, pretty fast!

fregante commented 4 years ago

Indeed, I see it now 🙌