search

tanmayrajani / notifications-preview-github

Browser Extension: preview GitHub notifications with same page pop-overs
https://chrome.google.com/webstore/detail/github-notifications-prev/kgilejfahkjidpaclkepbdoeioeohfmj?hl=en&gl=IN
MIT License
141 stars 15 forks source link

No notification number in the bubble if `Show only participating notifications` is enabled #95

Open darkred opened 4 years ago

darkred commented 4 years ago

(follow-up to https://github.com/tanmayrajani/notifications-preview-github/issues/89#issuecomment-618091190)

(Tested extension 20.4.22 in a fresh Chrome 81/Firefox 75 profile)

if I enable Show only participating notifications then the notification number in the bubble is no longer displayed, even if Show notification number in blue bubble remains enabled.

The following error is repeatedly shown in console :

(github-notifications-preview.js:386) 
Uncaught (in promise) TypeError: Cannot read property 'textContent' of null 
     at $i4sc$var$updateUnreadCount

Screenshot comparison having Show only participating notifications :

Disabled --> notification number (4) is displayed ok ![2020-05-01_214015](https://user-images.githubusercontent.com/723651/80832096-b305bc00-8bf4-11ea-8917-d038b9167082.jpg)
Enabled --> notification number (2) is missing ![2020-05-01_214100](https://user-images.githubusercontent.com/723651/80832156-c6b12280-8bf4-11ea-82f1-580cb479abc0.jpg)