tanmng / docker-chevereto-free

Dockerfiles for various release of Chevereto Free
38 stars 26 forks source link

PHP7.3 required when using :installer tag #24

Closed Zyrohex closed 3 years ago

Zyrohex commented 3 years ago

As title says, if I pull down the :installer tag to pull the latest installer.php from https://github.com/Chevereto/installer, I get the following error:

Composer detected issues in your platform:

Your Composer dependencies require a PHP version ">= 7.3.0". You are running 7.2.11.

When I looked at your :installer tag on docker-hub, I noticed it has references for PHP7.2 even tho the dockerfile on github list php7.3. If I run php -v inside the container it also reports: PHP 7.2.11

tanmng commented 3 years ago

Thanks @nmartin84 for spotting this issue. I'll get this addressed ASAP

tanmng commented 3 years ago

I believe the issue is now fixed. I pushed a new image of the image and it's now using php 7.3 as required.

Output of the command docker inspect nmtan/chevereto:installer (omitting the irrelevant parts)

[
    {
        "Id": "sha256:3548c2cfe3684394ac619d04d8e0f08da725325090c8abcd97a97278292c21fc",
        "RepoTags": [
            "nmtan/chevereto:installer"
        ],
        "RepoDigests": [
            "nmtan/chevereto@sha256:035cd083a9e8836d22cb0871b8ae6aa00c974bcb5ac7ff8e619cbd5bae5a4c3e"
        ],
        "Parent": "",
        "Comment": "",
        "Created": "2020-12-01T03:41:12.31833538Z",
        "Container": "aec545572d809de001edf19765148e04e084c24a9afd94a18ed788a123a0e373",
        "ContainerConfig": {
            "Hostname": "aec545572d80",
            "Domainname": "",
            "User": "",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "ExposedPorts": {
                "80/tcp": {}
            },
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "PHPIZE_DEPS=autoconf \t\tdpkg-dev \t\tfile \t\tg++ \t\tgcc \t\tlibc-dev \t\tmake \t\tpkg-config \t\tre2c",
                "PHP_INI_DIR=/usr/local/etc/php",
                "APACHE_CONFDIR=/etc/apache2",
                "APACHE_ENVVARS=/etc/apache2/envvars",
                "PHP_EXTRA_BUILD_DEPS=apache2-dev",
                "PHP_EXTRA_CONFIGURE_ARGS=--with-apxs2 --disable-cgi",
                "PHP_CFLAGS=-fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64",
                "PHP_CPPFLAGS=-fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64",
                "PHP_LDFLAGS=-Wl,-O1 -pie",
                "GPG_KEYS=CBAF69F173A0FEA4B537F470D66C9593118BCCB6 F38252826ACD957EF380D39F2F7956BC5DA04B5D",
                "PHP_VERSION=7.3.24",
                "PHP_URL=https://www.php.net/distributions/php-7.3.24.tar.xz",
                "PHP_ASC_URL=https://www.php.net/distributions/php-7.3.24.tar.xz.asc",
                "PHP_SHA256=78b0b417a147ab7572c874334d11654e3c61ec5b3f2170098e5db02fb0c89888",
                "CHEVERETO_DB_HOST=db",
                "CHEVERETO_DB_USERNAME=chevereto",
                "CHEVERETO_DB_PASSWORD=chevereto",
                "CHEVERETO_DB_NAME=chevereto",
                "CHEVERETO_DB_PREFIX=chv_",
                "CHEVERETO_DB_PORT=3306"
            ],
        "Config": {
            ....
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "PHPIZE_DEPS=autoconf \t\tdpkg-dev \t\tfile \t\tg++ \t\tgcc \t\tlibc-dev \t\tmake \t\tpkg-config \t\tre2c",
                "PHP_INI_DIR=/usr/local/etc/php",
                "APACHE_CONFDIR=/etc/apache2",
                "APACHE_ENVVARS=/etc/apache2/envvars",
                "PHP_EXTRA_BUILD_DEPS=apache2-dev",
                "PHP_EXTRA_CONFIGURE_ARGS=--with-apxs2 --disable-cgi",
                "PHP_CFLAGS=-fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64",
                "PHP_CPPFLAGS=-fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64",
                "PHP_LDFLAGS=-Wl,-O1 -pie",
                "GPG_KEYS=CBAF69F173A0FEA4B537F470D66C9593118BCCB6 F38252826ACD957EF380D39F2F7956BC5DA04B5D",
                "PHP_VERSION=7.3.24",
                "PHP_URL=https://www.php.net/distributions/php-7.3.24.tar.xz",
                "PHP_ASC_URL=https://www.php.net/distributions/php-7.3.24.tar.xz.asc",
                "PHP_SHA256=78b0b417a147ab7572c874334d11654e3c61ec5b3f2170098e5db02fb0c89888",
                "CHEVERETO_DB_HOST=db",
                "CHEVERETO_DB_USERNAME=chevereto",
                "CHEVERETO_DB_PASSWORD=chevereto",
                "CHEVERETO_DB_NAME=chevereto",
                "CHEVERETO_DB_PREFIX=chv_",
                "CHEVERETO_DB_PORT=3306"
            ],
            "Cmd": [
                "apache2-foreground"
            ],
            "Image": "sha256:ea14ad1a81aff0a43fee80f0c4d16bf6b7a8ee60a9850e1f4ca4c402c46f7ecb",
            "Volumes": {
                "/var/www/html/images": {}
            },
            "WorkingDir": "/var/www/html",
            "Entrypoint": [
                "docker-php-entrypoint"
            ],
            "OnBuild": null,
            "Labels": {
                "build_signature": "Chevereto installer; built on 2020-12-01T03:39:11Z; Using PHP version 7.3.24",
                "maintainer": "Tan Nguyen <tan.mng90@gmail.com>",
                "org.label-schema.license": "Apache-2.0",
                "org.label-schema.name": "Chevereto Free",
                "org.label-schema.url": "https://github.com/tanmng/docker-chevereto",
                "org.label-schema.vcs-url": "https://github.com/tanmng/docker-chevereto"
            },
            "StopSignal": "SIGWINCH"
        },
        ....
    }
]

I tried this out and it appeared to work just fine. Please try this image on your side and let me know if you have any further questions. I'll probably close this issue in ~2 days. Cheers

Zyrohex commented 3 years ago

That worked, I think we can close this out. I did come across another issue which looks to be a persistence issue on the data, but i'll open a separate issue for that.