search

tanner87661 / IoTTStick

This is the support repository for the IoTT Stick, port modules and hat devices
31 stars 16 forks source link

1.6.5 Save to File missing node config #49

Closed ggee closed 2 months ago

ggee commented 7 months ago

When saving to file from the Configuration tab, the json file saved does not have any of the nodes config in it.

ggee commented 7 months ago

and 1.6.4

tanner87661 commented 7 months ago

Just tested it on two different Sticks. Saved files are complete and error free JSON. But it appears there might be a problem with reading back large files. Will have a closer look.

ggee commented 7 months ago

Interesting. I am looking in the json file and can't find the node.cfg section.

ggee commented 7 months ago

My purplehat is 1.6.3 and the saved config also missing pgNodeCfg.

ggee commented 6 months ago

Did a little more testing. From debugging the Arduino compile issue, I see the problem existed back in 1.6.0.

Also looking at the node, I noticed I could CTRL-click the Save button on the node screen just for the node.cfg. That returned a file with just an empty array [ ].

ggee commented 6 months ago

I don't have access to latest code to do pull request. A line was missing in WebServer.ino to get the node cfg file.

addFileToTx(client, "node", 0, "pgNodeCfg", 1); //add file

  if (thisCmd == "CfgFiles") //Config Request Format: {"Cmd":"CfgFiles", "Type":"pgxxxxCfg"}
  {
    keepAlive = millis() + keepAliveInterval;
    uint16_t fileSelector = 0xFFFF;
    if (doc.containsKey("Type"))
      fileSelector = doc["Type"];
    addFileToTx(client, "", 0, "pgStartFile", 2); //reset file list
    if (fileSelector & 0x0001)  
      addFileToTx(client, "node", 0, "pgNodeCfg", 1); //add file
    if (fileSelector & 0x0002)  
      addFileToTx(client, "mqtt", 0, "pgMQTTCfg", 1); //add file
tanner87661 commented 6 months ago

Yes, I looked into it earlier this evening and fixed it. Thanks for finding the problem.

Hans

From: ggee @.> Sent: Saturday, December 9, 2023 10:23 PM To: tanner87661/IoTTStick @.> Cc: Hans R. Tanner @.>; Comment @.> Subject: Re: [tanner87661/IoTTStick] 1.6.5 Save to File missing node config (Issue #49)

I don't have access to latest code to do pull request. A line was missing in WebServer.ino to get the node cfg file.

addFileToTx(client, "node", 0, "pgNodeCfg", 1); //add file

if (thisCmd == "CfgFiles") //Config Request Format: {"Cmd":"CfgFiles", "Type":"pgxxxxCfg"} { keepAlive = millis() + keepAliveInterval; uint16_t fileSelector = 0xFFFF; if (doc.containsKey("Type")) fileSelector = doc["Type"]; addFileToTx(client, "", 0, "pgStartFile", 2); //reset file list if (fileSelector & 0x0001)
addFileToTx(client, "node", 0, "pgNodeCfg", 1); //add file if (fileSelector & 0x0002)
addFileToTx(client, "mqtt", 0, "pgMQTTCfg", 1); //add file

— Reply to this email directly, view it on GitHub https://github.com/tanner87661/IoTTStick/issues/49#issuecomment-1848845399 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAI4UE5LI7U23HHBJXPMW3YIUTJFAVCNFSM6AAAAAA7YLT3WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYHA2DKMZZHE . You are receiving this because you commented. https://github.com/notifications/beacon/AGAI4UGAFWABIJ4LSWQFZODYIUTJFA5CNFSM6AAAAAA7YLT3WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTOGMSFO.gif Message ID: @. @.> >

tanner87661 commented 6 months ago

Hi Greg

I have updated the prerelease branch with the current code 1.6.5dev

Hans

From: ggee @.> Sent: Saturday, December 9, 2023 10:23 PM To: tanner87661/IoTTStick @.> Cc: Hans R. Tanner @.>; Comment @.> Subject: Re: [tanner87661/IoTTStick] 1.6.5 Save to File missing node config (Issue #49)

I don't have access to latest code to do pull request. A line was missing in WebServer.ino to get the node cfg file.

addFileToTx(client, "node", 0, "pgNodeCfg", 1); //add file

if (thisCmd == "CfgFiles") //Config Request Format: {"Cmd":"CfgFiles", "Type":"pgxxxxCfg"} { keepAlive = millis() + keepAliveInterval; uint16_t fileSelector = 0xFFFF; if (doc.containsKey("Type")) fileSelector = doc["Type"]; addFileToTx(client, "", 0, "pgStartFile", 2); //reset file list if (fileSelector & 0x0001)
addFileToTx(client, "node", 0, "pgNodeCfg", 1); //add file if (fileSelector & 0x0002)
addFileToTx(client, "mqtt", 0, "pgMQTTCfg", 1); //add file

— Reply to this email directly, view it on GitHub https://github.com/tanner87661/IoTTStick/issues/49#issuecomment-1848845399 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAI4UE5LI7U23HHBJXPMW3YIUTJFAVCNFSM6AAAAAA7YLT3WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYHA2DKMZZHE . You are receiving this because you commented. https://github.com/notifications/beacon/AGAI4UGAFWABIJ4LSWQFZODYIUTJFA5CNFSM6AAAAAA7YLT3WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTOGMSFO.gif Message ID: @. @.> >

ggee commented 6 months ago

I'll try it out. When you created the Prerelease branch, was it based off the latest master? Just concerned since github says

This branch is 3 commits ahead of, 50 commits behind master.

Don't want to loose any data.

tanner87661 commented 6 months ago

Hi Greg

The master has the latest published official release, the prerelease has any state of development. I work locally on the prerelease, then merge it to Github prerelease, and if it is an official release, I merge it into the master.

Hope that helps

Hans

From: ggee @.> Sent: Saturday, December 16, 2023 2:31 PM To: tanner87661/IoTTStick @.> Cc: Hans R. Tanner @.>; Comment @.> Subject: Re: [tanner87661/IoTTStick] 1.6.5 Save to File missing node config (Issue #49)

I'll try it out. When you created the Prerelease branch, was it based off the latest master? Just concerned since github says

This branch is 3 commits ahead of https://github.com/tanner87661/IoTTStick/compare/master...Prerelease , 50 commits behind https://github.com/tanner87661/IoTTStick/compare/Prerelease...master master.

— Reply to this email directly, view it on GitHub https://github.com/tanner87661/IoTTStick/issues/49#issuecomment-1858913176 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAI4UG6RW6I5AGE2FMYBZTYJXZF3AVCNFSM6AAAAAA7YLT3WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYHEYTGMJXGY . You are receiving this because you commented. https://github.com/notifications/beacon/AGAI4UFWNTKZNUVM673PWOLYJXZF3A5CNFSM6AAAAAA7YLT3WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTOZTBZQ.gif Message ID: @. @.> >

ggee commented 6 months ago

Thanks for the clarification. The save works in the prerelease branch.

ggee commented 6 months ago

Would you be able to tag your local commit from the original 1.6.5 and push to master? From your latest video, sounds like it might be a while before another update.

tanner87661 commented 6 months ago

Hi Greg

I refreshed the Prerelease today with the current code. I do not freeze source code as if there is a bug it will be fixed with the next release. Therefore I can’t upload a master 1.6.5, it will have to wait until I release 1.6.6 (which pretty much is what I uploaded today).

Hans

From: ggee @.> Sent: Sunday, December 24, 2023 12:20 PM To: tanner87661/IoTTStick @.> Cc: Hans R. Tanner @.>; Comment @.> Subject: Re: [tanner87661/IoTTStick] 1.6.5 Save to File missing node config (Issue #49)

Would you be able to tag your local commit from the original 1.6.5 and push to master? From your latest video, sounds like it might be a while before another update.

— Reply to this email directly, view it on GitHub https://github.com/tanner87661/IoTTStick/issues/49#issuecomment-1868561807 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAI4UGOE7W7VGE6IVUBTNDYLBP3TAVCNFSM6AAAAAA7YLT3WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGU3DCOBQG4 . You are receiving this because you commented. https://github.com/notifications/beacon/AGAI4UAAZHZM372DGHWPCVTYLBP3TA5CNFSM6AAAAAA7YLT3WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTPL76Y6.gif Message ID: @. @.> >

tanner87661 commented 2 months ago

Fixed in 1.6.6