tanner87661 / LocoNetESP32HB

LocoNet Library for ESP32 with Hybrid (UART Receiver, Bit level transmitter)
9 stars 0 forks source link

ESP32 timer API has changed in version 3.0 #1

Open 2sk21 opened 3 months ago

2sk21 commented 3 months ago

I have successfully been able to use this library to create my own code to run on an ESP32 connected to your excellent Loconet breakout board. However, the Timer API has changed in version 3.0 of the Arduino ESP32 support code. I tried updating it myself but I was unable to get it to work properly. I wonder if you can take a look at this: https://docs.espressif.com/projects/arduino-esp32/en/latest/api/timer.html Thanks!

tanner87661 commented 3 months ago

That is the original version. Try to use the current one I am using in the IoTT Stick. https://github.com/tanner87661/IoTTStick/tree/master/Sketchbook/libraries/IoTT_LocoNetESP32HB

Best wishes

Hans

From: 2sk21 @.> Sent: Tuesday, June 11, 2024 12:36 PM To: tanner87661/LocoNetESP32HB @.> Cc: Subscribed @.***> Subject: [tanner87661/LocoNetESP32HB] ESP32 timer API has changed in version 3.0 (Issue #1)

I have successfully been able to use this library to create my own code to run on an ESP32 connected to your excellent Loconet breakout board. However, the Timer API has changed in version 3.0 of the Arduino ESP32 support code. I tried updating it myself but I was unable to get it to work properly. I wonder if you can take a look at this: https://docs.espressif.com/projects/arduino-esp32/en/latest/api/timer.html Thanks!

— Reply to this email directly, view it on GitHub https://github.com/tanner87661/LocoNetESP32HB/issues/1 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAI4UBFFOKHY3WV4ZWV3BTZG4RODAVCNFSM6AAAAABJEWLLF2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DMOBVGAYTMMA . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AGAI4UBJB7HOP525IN3QAV3ZG4RODA5CNFSM6AAAAABJEWLLF2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHIXYQXOA.gif Message ID: @. @.> >

2sk21 commented 3 months ago

Thanks for your prompt reply - I took a look at the IoTT stick code but I notice it is still using the older 2.0 timer API. My original plan was to try to update your code to the new timer API myself and submit a pull request but after an unsuccessful day of trying the changes, I have to admit the perhaps I don't understand your code as well as I thought :-)

tanner87661 commented 3 months ago

Hi 2sk21

The new API does not look that much different, just some different parameters for some commands.

Where were you running into problems trying to convert the lib to the new API?

And more important: What would be the value of changing the code to the new API as long as the old one still exists? If it is difficult to do, why should we change it as long as it works?

Best wishes

Hans

From: 2sk21 @.> Sent: Tuesday, June 11, 2024 2:25 PM To: tanner87661/LocoNetESP32HB @.> Cc: Hans R. Tanner @.>; Comment @.> Subject: Re: [tanner87661/LocoNetESP32HB] ESP32 timer API has changed in version 3.0 (Issue #1)

Thanks for your prompt reply - I took a look at the IoTT stick code but I notice it is still using the older 2.0 timer API. My original plan was to try to update your code to the new timer API myself and submit a pull request but after an unsuccessful day of trying the changes, I have to admit the perhaps I don't admit your code as well as I thought :-)

— Reply to this email directly, view it on GitHub https://github.com/tanner87661/LocoNetESP32HB/issues/1#issuecomment-2161364956 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAI4UAP7MZTNXOFMXMRWN3ZG46IRAVCNFSM6AAAAABJEWLLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGM3DIOJVGY . You are receiving this because you commented. https://github.com/notifications/beacon/AGAI4UF5H7BVL6A6VSNQ32LZG46IRA5CNFSM6AAAAABJEWLLF2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUA2PH5Y.gif Message ID: @. @.> >

2sk21 commented 3 months ago

I should reiterate that this is not really a big problem. I was successfully able to write my program using this library on Arduino-ESP 2.0.17. But it's really frustrating that Espressif has arbitrarily made this breaking change. In the future, as version 3.0 of the Arduino-ESP support becomes more widely used, users will find it to be a problem.

I was able to make the obvious changes to your code for the new timer calls. The code then compiled properly but I am not able to receive any LocoNet packets. I can post the changes if you want.

tanner87661 commented 3 months ago

Hi

Yes, please post it. Even though not high priority right now, I may be able to merge towards the new version.

Thanks

Hans

From: 2sk21 @.> Sent: Wednesday, June 12, 2024 5:54 AM To: tanner87661/LocoNetESP32HB @.> Cc: Hans R. Tanner @.>; Comment @.> Subject: Re: [tanner87661/LocoNetESP32HB] ESP32 timer API has changed in version 3.0 (Issue #1)

I should reiterate that this is not really a big problem. I was successfully able to write my program using this library on Arduino-ESP 2.0.17. But it's really frustrating that Espressif has arbitrarily made this breaking change. In the future, as version 3.0 of the Arduino-ESP support becomes more widely used, users will find it to be a problem.

I was able to make the obvious changes to your code for the new timer calls. The code then compiled properly but I am not able to receive any LocoNet packets. I can post the changes if you want.

— Reply to this email directly, view it on GitHub https://github.com/tanner87661/LocoNetESP32HB/issues/1#issuecomment-2162594642 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAI4UFNW7WD4CU7SR6WRX3ZHALDXAVCNFSM6AAAAABJEWLLF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSGU4TINRUGI . You are receiving this because you commented. https://github.com/notifications/beacon/AGAI4UCEARXRMHGOBASXHQLZHALDXA5CNFSM6AAAAABJEWLLF2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUA42JVE.gif Message ID: @. @.> >