search

tannercollin / standardnotes-fs

Mount your Standard Notes as a filesystem.
GNU General Public License v3.0
148 stars 12 forks source link

Moving in tags not supported #17

Closed LudwikJaniuk closed 5 years ago

LudwikJaniuk commented 5 years ago

The feature seemingly created in #4 seems great but could be better. My use case is I want to massively edit tags with help of scripts etc. However, it seems I cannot move files between the tag directories here. Is there another way of accomplishing changing tags? If not, I would want to ask for this feature in the future.

tannercollin commented 5 years ago

I agree this would be useful.

It would also take a lot of time to code and I lack the motivation to do it, unfortunately. I'll definitely keep it on the back burner!

LudwikJaniuk commented 5 years ago

Thank you for being open about the chances of getting it done.

tannercollin commented 5 years ago

Implemented in 1e00b96d256c1116501ca019aa7577cef1bc5b17.

Tagging is done by mv, untagging is done with rm. Stay away from cp for tagging, it likes to destroy notes since it calls truncate() if the note is already tagged.

Could you please test it and let me know how it works? Make sure to back your account up first!

LudwikJaniuk commented 5 years ago

Will do!

LudwikJaniuk commented 5 years ago

(that cp behavior sounds dangerous tho xD)

LudwikJaniuk commented 5 years ago

IT SEEMS TO WORK FLAWLESSLY!

LudwikJaniuk commented 5 years ago

mv from one tag folder to another does not work tho.

LudwikJaniuk commented 5 years ago

(In the sense that it adds the new tag, but leaves the old)

tannercollin commented 5 years ago

cp bug fixed in 05986171f973ce25e1f191e1eb4512ccd042a00c.

LudwikJaniuk commented 5 years ago

I feel like this issue can be closed then