search

tannerdolby / eleventy-plugin-metagen

Eleventy shortcode that generates document metadata
https://www.npmjs.com/package/eleventy-plugin-metagen
MIT License
41 stars 3 forks source link

Update version in package.json #6

Closed tannerdolby closed 3 years ago

tannerdolby commented 3 years ago

The plugin has seen some needed improvements in the last week thanks to the keen eye of @JbIPS !

Therefore, I think it's time to increment the version from 1.0.3 to 1.0.4 or potentially 1.1.4 as discovering the plugin does support template variables is more than a "patch improvement" and very well could warrant a MINOR version increment. Also, the fix with og:img being replaced with og:image to satisfy the spec, warrants a PATCH version increment.

After I do some local testing of the changes merged into master within the last week, I will update the package version to reflect the MINOR and PATCH version increments necessary.

JbIPS commented 3 years ago

I agree with you on the MINOR update. But if you're following semver, next version should be 1.1.0 since minor bump reset the patches.

P.S.: I don't know if you've ever use this but I encourage you to use npm version minor to do so, since it will take care of a lot of things for you :wink:

tannerdolby commented 3 years ago

Ah, yes you are correct that the minor bump will reset the patches. I will close this when I update things later today.

Thank you for the reminder and for mentioning npm version minor 😃

tannerdolby commented 3 years ago

Closed via 65dc71f