Allow `widths` array to have 10 items

tannerdolby / eleventy-plugin-sharp-respimg

Eleventy plugin which performs build-time image transformations and generates responsive image markup.

https://www.npmjs.com/package/eleventy-plugin-sharp-respimg

MIT License

8 stars 3 forks source link

Allow `widths` array to have 10 items #3

Closed JeroenDekker82 closed 2 years ago

JeroenDekker82 commented 2 years ago

Currently the widths array only allows 9 items, but the error message says it allows 10

tannerdolby commented 2 years ago

@JeroenDekker82 Thank you for your contribution!

tannerdolby commented 2 years ago

v1.3.5 is live and includes your changes! Feel free to create an issue or PR in the future if you would like to see anything added/improved.

JeroenDekker82 commented 2 years ago

Thank you! Why is the widths attribute limited, btw?

tannerdolby commented 2 years ago

No problem! I was beginning to ask myself the same question when you first opened this PR 😅 I believe 10 was the arbitrary "ceiling" that I used when first developing the plugin.

There doesn't seem to be any reliance/reasoning for a limit at all. I'm going to remove the widths attribute limit and publish v1.3.6 tonight or tomorrow.