search

tannerlinsley / nz-toggle

Dual and triple-state toggles for AngularJS
http://codepen.io/anon/pen/yNjyME
40 stars 30 forks source link

JavaScript minification ability #22

Closed nestdimon closed 8 years ago

tannerlinsley commented 8 years ago

I believe this is automatically done with NgAnnotate in the gulpfile. Is the nz-toggle.min.js file no good?

nestdimon commented 8 years ago

There is no problem if someone use minified version of js file, but what if not minified file with some changes used? I personally ran into this issue with maven project because minify-maven-plugin can't automatically adapt js code for angular.

tannerlinsley commented 8 years ago

That makes sense. So let it be written...

On Thu, Aug 6, 2015 at 8:27 AM NDS notifications@github.com wrote:

There is no problem if someone use minified version of js file, but what if not minified file with some changes included? I personally ran into this issue with maven project because minify-maven-plugin can't automatically adapt js code for angular.

— Reply to this email directly or view it on GitHub https://github.com/tannerlinsley/nz-toggle/pull/22#issuecomment-128391645 .

tannerlinsley commented 8 years ago

So let it be done!

nestdimon commented 8 years ago

Ha ha) Thank you! :yum: