tannerlinsley / nz-toggle

Dual and triple-state toggles for AngularJS
http://codepen.io/anon/pen/yNjyME
40 stars 29 forks source link

Conflicts with Material Design tabs #24

Open sturay opened 9 years ago

sturay commented 9 years ago

It appears that when the tri-state toggle elements are included within an (ng-material 0.10.1) area, the tab area briefly duplicates the rendering of the toggles once, sometimes twice. As you can see below, it duplicates the set of three. nz-toggle They settle down after the additional elements wink in and out two or three times. I am investigating this in my spare time locally to see where any potential conflict lies. It just manifested this morning after the ng-material update which, to be fair, will be where I look first. It does appear that the Angular Material team are aware of memory leaks with md-tabs and are working on that issue. Could be something else though.

tannerlinsley commented 9 years ago

Hmm let me know what you find

On Wed, Aug 12, 2015 at 7:02 AM Stuart Harding notifications@github.com wrote:

It appears that when the tri-state toggle elements are included within an (ng-material 0.10.1) area, the tab area briefly duplicates the rendering of the toggles once, sometimes twice. As you can see below, it duplicates the set of three. [image: nz-toggle] https://cloud.githubusercontent.com/assets/5795272/9224219/be84e08e-40f8-11e5-9260-85b6d909aa6e.jpg They settle down after the additional elements wink in and out two or three times. I am investigating this in my spare time locally to see where any potential conflict lies. It just manifested this morning after the ng-material update which, to be fair, will be where I look first.

— Reply to this email directly or view it on GitHub https://github.com/tannerlinsley/nz-toggle/issues/24.

sturay commented 8 years ago

Apologies. Not been able to fully investigate and discover the reason why the elements were doubling due to workload. We opted to simply remove the toggle blocks from the md-tab body and used routes to control the tabbing instead. that worked a treat (but without the swooshy animation) and has rendered the issue null from our perspective. Angular Material has undergone a few upgrades since the issue was stumbled upon so it may well have been corrected, now at 11.2.