tannerlinsley / nz-toggle

Dual and triple-state toggles for AngularJS
http://codepen.io/anon/pen/yNjyME
40 stars 29 forks source link

Distribution Files Log to Console #28

Closed hawkerm closed 8 years ago

hawkerm commented 8 years ago

The files in the dist directory shouldn't output to the console. When including it as a library you don't want a ton of extra output in your browser. It makes debugging your own application a lot harder.

tannerlinsley commented 8 years ago

I agree. I'll accept a PR On Tue, Dec 22, 2015 at 10:03 AM Michael A. Hawker notifications@github.com wrote:

The files in the dist directory shouldn't output to the console. When including it as a library you don't want a ton of extra output in your browser. It makes debugging your own application a lot harder.

— Reply to this email directly or view it on GitHub https://github.com/tannerlinsley/nz-toggle/issues/28.

lavor commented 8 years ago

I have the same issue, when button is dragged the console log is owerwhelmed with info messages:

nz-toggle-logging-of-dragging

ckr commented 8 years ago

Removed.

lavor commented 8 years ago

Hi, sorry I don't understand, how can be console logs removed, when you changed with your commit just readme file?

ckr commented 8 years ago

They where removed in a previous commit.

lavor commented 8 years ago

Problem is probably in "mismatch Version declared in the json (2.1.0) is different than the resolved one (2.2.0)": $ bower install nz-toggle bower nz-toggle#* cached https://github.com/tannerlinsley/nz-toggle.git#2.1.0 bower nz-toggle#* validate 2.1.0 against https://github.com/tannerlinsley/nz-toggle.git# bower nz-toggle#* new version for https://github.com/tannerlinsley/nz-toggle.git# bower nz-toggle#* resolve https://github.com/tannerlinsley/nz-toggle.git# bower nz-toggle#* checkout 2.2.0 bower nz-toggle#* mismatch Version declared in the json (2.1.0) is different than the resolved one (2.2.0) bower nz-toggle#\ resolved https://github.com/tannerlinsley/nz-toggle.git#2.2.0 bower nz-toggle#~2.2.0 install nz-toggle#2.2.0

ckr commented 8 years ago

Sorry forgot to update the version in the bower and npm files.

lavor commented 8 years ago

Now, it is OK, thanks.