search

tannerlinsley / tour

Touring and on-boarding for javascript applications
http://tourjs.github.io/tour
MIT License
91 stars 18 forks source link

Position: floating #7

Open Hypercubed opened 8 years ago

Hypercubed commented 8 years ago

Sometimes we don't want to position the dialog over an element, or perhaps the element is too large. In these cases position: floating would be useful. This might also be a good default if the target is undefined or missing.

tannerlinsley commented 8 years ago

I am pretty sure when an element is too large, the tour box will move inside of the element to the prioritized placement options. As for no element, that would be an easy addition, to just have it centered on the screen.

Hypercubed commented 8 years ago

Centered on screen is what I would expect from placement: floating. Here is what it looks like with a big element:

screen shot 2016-07-02 at 3 15 58 pm

tannerlinsley commented 8 years ago

What about a full screen element? On Sat, Jul 2, 2016 at 12:17 AM Jayson Harshbarger notifications@github.com wrote:

Centered on screen is what I would expect from placement: floating. Here is what it looks like with a big element:

[image: screen shot 2016-07-02 at 3 15 58 pm] https://cloud.githubusercontent.com/assets/509946/16538736/1b992162-4068-11e6-8a11-ad2193d2536d.png

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/tourjs/tour/issues/7#issuecomment-230086443, or mute the thread https://github.com/notifications/unsubscribe/AFUmCbYwaZ9pVfqa3vOmuOUnX1mBQe5nks5qRgKJgaJpZM4JDmcE .

tannerlinsley commented 8 years ago

Ss for that screenshot, it should fit exactly in the open space. It looks like the margins are not being taken into account. We should log out the max height and the actual target height plus margin On Sat, Jul 2, 2016 at 12:20 AM Tanner Linsley tannerlinsley@gmail.com wrote:

What about a full screen element? On Sat, Jul 2, 2016 at 12:17 AM Jayson Harshbarger < notifications@github.com> wrote:

Centered on screen is what I would expect from placement: floating. Here is what it looks like with a big element:

[image: screen shot 2016-07-02 at 3 15 58 pm] https://cloud.githubusercontent.com/assets/509946/16538736/1b992162-4068-11e6-8a11-ad2193d2536d.png

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/tourjs/tour/issues/7#issuecomment-230086443, or mute the thread https://github.com/notifications/unsubscribe/AFUmCbYwaZ9pVfqa3vOmuOUnX1mBQe5nks5qRgKJgaJpZM4JDmcE .