ESM bundle - Githubissues

hakimio commented 3 years ago

Chose to do ES module build using rollup for the following reasons:

Generated file is human readable.
Rollup can also be used for code minifcation.

Few other things to note:

Updated TS to version 4.2 because 4.1 had some bug preventing "@rollup/plugin-typescript" usage.
Transpiled code is now split into 3 folders: cjs, esm and types.

Feedback is welcome.

hakimio commented 3 years ago

@tannerntannern any plans to review this?

tannerntannern commented 3 years ago

Hey, so sorry for the delay -- yes I plan to, and I've peeked at the code a few times already. I've just been very busy with work and planning to move to a new apartment. Should be able to have something either tonight or tomorrow.

On Wed, Apr 28, 2021, 7:40 AM Tomas Rimkus @.***> wrote:

@tannerntannern https://github.com/tannerntannern any plans to review this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tannerntannern/ts-mixer/pull/37#issuecomment-828422094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIQIUUXLLYQNYA7YPYQJDDTK765FANCNFSM43GQHYAQ .

tannerntannern commented 3 years ago

This all looks good! Thank you very much for the contribution @hakimio!!

tannerntannern / ts-mixer

ESM bundle #37