tanqinyong / pe

0 stars 0 forks source link

Unable to record people's whose names contain s/o #3

Open tanqinyong opened 7 months ago

tanqinyong commented 7 months ago

When the following command was entered: add n/John Doe s/o vivian p/98765432 e/johnd@example.com

The following incorrect error is shown: "Schedule names should be alphanumeric"

image.png

Steps to reproduce:

  1. Enter the command given above.

Expected:

  1. Input can be taken in or is parsed accordingly

Actual:

  1. It is rejected with the incorrect error message.

Given that there may be users from other races which may have different naming traditions, it would be good to allow strings such as "s/o" in the name.

nus-pe-bot commented 7 months ago

Team's Response

Also an misunderstanding in the input of valid input for name for adding person, which caused inconveniences to the users.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names with special characters d/o are not accepted

When typing "add n/Jane d/o Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01", the name is not accepted and the following error message as shown in the screenshot is returned. This is different from the error caused by other special characters such as 's/o' as that is incorrectly thought of as a schedule, whereas names with 'd/o' are not accepted as valid names.

Screen Shot 2024-04-19 at 4.23.53 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#632] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** It is still a feature flaw to not accept such inputs. As per course website, ![image.png](https://raw.githubusercontent.com/tanqinyong/pe/main/files/1af4bb37-b3ba-4c93-9a7a-8ce46be42956.png)