tanqinyong / pe

0 stars 0 forks source link

Moddie accepts invalid dates #9

Open tanqinyong opened 7 months ago

tanqinyong commented 7 months ago

image.png

To reproduce this: simply enter a schedule date with incorrect dates like 30th Feb and it will accept. This is wrong as it should not be accepting these dates.

nus-se-script commented 6 months ago

Team's Response

Although, the application accepts an invalid date, we believe that it is unlikely to affect normal operations of our product and really appears very rarely in situations and causes a minor inconvenience only. In the scope of our application, target users would not have schedules that occurs in invalid dates. Nonetheless, we have taken in extreme cases of invalid dates and thank you for pointing this out!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Users are very likely to make typos that makes their dates invalid, especially when scheduling many appointments.

Given that the whole premise of the application is a scheduling application, date validation should be a high priority core feature for your application.

As the target user provided by the team is generic and the application is meant to be versatile for many different scheduling purposes, let's come up with the following scenario below:

The user is a SoC student, recording all his classes for the week, CCA meetings, and friend meet ups. Assuming he has 2 classes a day (10 classes/week) , 2 CCA meetings a week and hangs out with his friends 2 times a week, he would have to put in 14 different timings/dates per week.

The user will most likely make a typo (32, instead of 31) during the process and cause an inconvenience (user will have to re-enter/update/delete schedule). In fact, the users may not even know they made this error until it's too late (user misses his appointment or goes at a different date).

I strongly believe that a scheduling application that does not do basic date validation and accepts invalid dates, at the very least causes occasional inconvenices to some users who are prone to typos.