search

tanrax / RSSingle

Merge multiple feeds (RSS/Atom/JSON) into a single RSS feed.
Apache License 2.0
12 stars 4 forks source link

Initial version of CI for RSSingle #3

Closed shymega closed 6 months ago

shymega commented 1 year ago

Hi @tanrax!

As part of our new collaboration, I've made an initial version for automated CI for RSSingle.

It needs macOS to work first, so I've commented out a draft version of the pyinstaller aspect, so I'll make this PR a draft for now when we can discuss further, preferably in a GH issue for transparency (unless you want it private?), but this workflow tests on PRs and pushes to any branch, with flake8 across multiple Python versions. The pyinstaller aspect only runs if the flake8 check passes.

What do you think?

Signed-off-by: Dom Rodriguez shymega@shymega.org.uk

shymega commented 1 year ago

I'm also working on automated container image builds (for those who want to use a container), and Python linting/type checks. All this I don't expect you to merge, as it's your project, but I just wanted to help make it better.

shymega commented 1 year ago

Rebased and squashed the last two commits.

tanrax commented 1 year ago

What problems does MacOS have with pyinstaller?

shymega commented 1 year ago

I don't really remember, I worked on this a long time ago now in relative terms.

I think the issue was due to the way macOS launches pyinstaller-packaged applications. There was an issue with the fix I incorporated into the CI workflow. I'll probably adjust it to upload based on the 'runner', so Windows/macOS/Linux.

shymega commented 6 months ago

I've just adjusted the PR, I now need to work out how to create releases. Might be a bit noisy. I'll be testing on my fork, in a separate branch.