search

tanrax / RSSingle

Merge multiple feeds (RSS/Atom/JSON) into a single RSS feed.
Apache License 2.0
12 stars 4 forks source link

Explicitly define the return type of get_url_from_feed(config) #8

Closed shymega closed 1 year ago

shymega commented 1 year ago

This commit explicitly defines the return type of the get_url_from_feed(config) function.

Signed-off-by: Dom Rodriguez shymega@shymega.org.uk

tanrax commented 1 year ago

Hi @shymega ! I do not forget your changes. When I have some time I look at it. Thanks a lot!

shymega commented 1 year ago

@tanrax No worries. There's a lot of PRs, and I might have to rebase them when we get round to merging.

shymega commented 1 year ago

Hey @tanrax, I was just wondering if you'd had a chance to review these PRs? I'm sure you're busy as well as me. I've actually deployed RSSingle as a private GitHub Pages site (as there's tokens in the RSS feed list), and it works superbly well.

tanrax commented 1 year ago

How long has this been here? Sorry for the wait, at some point it disappeared from me EVERYTHING. My sincerest apologies.

shymega commented 1 year ago

@tanrax Probably months. It's a coincidence you found the PRs today, as I was planning to prod the PRs this evening. So this works out well. It wasn't a huge issue, it happens. I've had PRs left on some of my projects I've forgotten about before as well. Or my notifications display isn't working, etc.