search

tanrax / maza-ad-blocking

Simple, native and efficient local ad blocker. Only Bash.
https://maza-ad-blocking.andros.dev/
Apache License 2.0
1.78k stars 64 forks source link

Lint with shellcheck #6

Closed cdlm closed 4 years ago

cdlm commented 4 years ago

Shellcheck reports quite a few warnings on maza. I haven't investigated to check if they're that serious, but it would be reassuring to have a minimum of those, especially for a script that's going to be run under sudo.

tanrax commented 4 years ago

Thanks for the report. If you read the warnings carefully, they are almost all double-quote notices or an arrays notice. If you want to make me a pull request with the format improvements I will gladly accept it. Greetings