search

tanriol / digest

An outdated Brief fork
Other
15 stars 4 forks source link

digest lost images in some feed. #81

Open mantis3d opened 11 years ago

mantis3d commented 11 years ago

this is "http://songshuhui.net" feed in Brief

brief

and this is same one in Digest

digest

where are those images??

tanriol commented 11 years ago

What Digest version do you use? Works for me in 1.1.0

By the way, as Adam came back and integrated most Digest fixes into Brief, Digest users are advised to migrate back to Brief.

mantis3d commented 11 years ago

I use 1.1.0 too. Only a few feeds lost image, for example "http://portableapps.com" and "http://songshuhui.net", others are working fine.

tanriol commented 11 years ago

Hmm. Could you please open Digest with such a feed, right-click where the image should be, choose "Inspect element" and check whether there is an <img src="..."> tag and the address of the image?

mantis3d commented 11 years ago

Yes, there is a IMG tag, but it's not show, may be the position is wrong?

digest-b

and this is same one in Brief brief-b

tanriol commented 11 years ago

Hmm. I don't see anything bad, which is... pretty strange.

By the way, running Digest and Brief simultaneously in the same Firefox instance is definitely not recommended. They use the same database and do not synchronize with each other, so races and other consistency issues may occur.

ghost commented 11 years ago

Same problem here with various feeds from comic sites. Examples are: http://abstrusegoose.com/feed https://xkcd.com/rss.xml

<img> tags are there in the source but the images are not shown. In Brief everything works properly. I'm using Digest 1.1.0.

tanriol commented 11 years ago

Works for me with Digest 1.1.0 for xkcd.com at least. Are there any other addons that may cause this problem?

ghost commented 11 years ago

Are there any other addons that may cause this problem?

This seems to be the problem indeed. I just tried with a clean profile that has only Digest installed and the images show up correctly there. Sorry I did not think of this in the first place. However, Brief has no problems in my main Firefox profile...

I'll investigate this further and let you know when I find the offending/incompatible extension.

mantis3d commented 11 years ago

Well, I found that is the addon "RequestPolicy" cause the problem, after I turn on "Temporarily allow all requests", all images are showed. Or I add the feed web url to the destinations whitelist, images in this feed are showed. but I can't add the Digest to Origins whitelist. Why does Digest has this problem, but Brief is not?

tanriol commented 11 years ago

Digest and Brief use different means for feed display. As the following Digest versions, if any, will be based on Brief, this bug will go away.

ghost commented 10 years ago

I found that is the addon "RequestPolicy" cause the problem

Confirmed! Thanks for testing, I simply forgot it...

As the following Digest versions, if any, will be based on Brief

Any estimates on when a new version is expected?