search

tansanchian / pe

0 stars 0 forks source link

Incorrect Display Message for Editing Comapny #12

Open tansanchian opened 1 week ago

tansanchian commented 1 week ago

image.png

After editing a company, the display message is "Edited Person" instead of "Edited Company". Users will be confused and not sure which type of contact has been edited.

nus-pe-bot commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Cosmetic issue found in most of the success messages

image.png

Expected message should be (Number of) contacts listed! instead of (Number of) persons listed!

image.png

Reason: There could be a student and a company with John in their names and when the user try to run find John, the success message is 2 persons listed but company is not a person, hence better expected message should be 2 contacts listed.

[original: nus-cs2103-AY2425S1/pe-interim#3534] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the bug report!

We agree that it is a valid issue, but fixing it is less important than the work done in the current version of the product. However, we think it should be a feature flaw instead of a documentation bug.

Feature Flaw instead of Documentation Bug: The actual message is the same as stated in the UG. As this feature does work as specified by the UG but should have been designed to work differently.

From the website:

response.NotInScope: It is a valid issue, but fixing it is less important than the work done in the current version of the product e.g., it was not related to features delivered in v1.6 or lower priority than the work already done in v1.6.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** Very Low is only for cosmetic issue, this is obviously "Error message not specific enough", which is a severity low bug.