Allow statement_descriptor to be set on products

tansengming / stripe-rails

A Rails Engine for integrating with Stripe

MIT License

755 stars 123 forks source link

Allow statement_descriptor to be set on products #122

Closed jeanmartin closed 6 years ago

jeanmartin commented 6 years ago

Creating a Service Product allows a statement_descriptor to be set for service products.

This PR adds statement_descriptor to the products configuration builder and makes sure it is only set for service products.

jeanmartin commented 6 years ago

Don't know why the tests fail. Something about Unable to find chromedriver. I will try to re-trigger with a README change commit.

tansengming commented 6 years ago

Hi @jeanmartin thanks for the PR! I'll try to fix the test error. In the meantime, can you add a positive spect to the product builder spec? I.e. Let's have a spec to make sure that using statement_descriptor does not cause an error. Thanks.

jeanmartin commented 6 years ago

Hi, I added the field to the positive test that was already there. Hope this is ok.

tansengming commented 6 years ago

Yup it looks good thanks for the PR!