search

tansengming / stripe-rails

A Rails Engine for integrating with Stripe
MIT License
753 stars 123 forks source link

Remove Ping route to non-existant controller #200

Closed jamesprior closed 3 years ago

jamesprior commented 3 years ago

Pings controller was removed in https://github.com/tansengming/stripe-rails/commit/72734293db9ac477a95cd3586b50e0d5667b6f3f but the route remained.

I think there is a test for it too - should that also come out?

tansengming commented 3 years ago

thanks for this @jamesprior ! Yes please remove the tests too.

jamesprior commented 3 years ago

Looks like it was only the name of a test, which I updated since it looked like it wasn't used for pings.

I do see callback 'ping' in the list of callbacks which is missing from https://stripe.com/docs/api/events/types (assuming that's the right list) but I did not remove it.

tansengming commented 3 years ago

thanks @jamesprior this looks good!