search

tansengming / stripe-rails

A Rails Engine for integrating with Stripe
MIT License
753 stars 123 forks source link

Where can I find the list of breaking changes in v2.0.0? #202

Closed vfonic closed 3 years ago

vfonic commented 3 years ago

I just saw that there's stripe-rails v2 out for couple of months.

I tried to find out what are all the breaking changes, but I cannot find it anywhere.

Here's where I looked: This a little cryptic issue title (and content, at least from my point of view): V2 Deprecations: https://github.com/tansengming/stripe-rails/issues/95 This 404: https://github.com/tansengming/stripe-rails/blame/feature/rails6/lib/stripe/engine.rb#L13-L17 Changelog.md: https://github.com/tansengming/stripe-rails/blob/master/Changelog.md

Please let me know if I missed it somewhere and what I need to take care of when upgrading so that nothing breaks for my users.

Thank you!

tansengming commented 3 years ago

Hi @vfonic thanks for the sleuthing. The changelog should have the correct list of breaking changes

https://github.com/tansengming/stripe-rails/blob/master/Changelog.md#200pre-2020-05-29

It is basically dropping support for older versions of the Ruby, Rails and Stripe gem.

vfonic commented 3 years ago

Ugh! I was looking here: https://github.com/tansengming/stripe-rails/blob/master/Changelog.md#200-2020-09-18 and missed the pre release. 🤦

Thank you! 👍