search

tansengming / stripe-rails

A Rails Engine for integrating with Stripe
MIT License
753 stars 123 forks source link

Missing Webhook callbacks #212

Closed lesliepoolman closed 2 years ago

lesliepoolman commented 2 years ago

Hi!

I wanted to point out that there is a section of webhook callbacks missing from the gem that I am using in a project. The range of subscription_schedule events listed here. Speaking for myself, I am only really interested in a after_subscription_schedule_created callback, but I assume that others would find these useful as well. I will use the catchall as a workaround.

Thanks for all the hard work on this awesome gem!

tansengming commented 2 years ago

Hi @lesliepoolman thanks for pointing this out. I am a little busy right now so can't get to this right away.

However I recommend starting a Pull Request so I can get it out sooner. A bunch of folks have contributed to adding more callbacks over the years, e.g. https://github.com/tansengming/stripe-rails/pull/211 so you can use those as a starting point.

tansengming commented 2 years ago

Also thanks for the all the kind words! I appreciate it!

lesliepoolman commented 2 years ago

Also thanks for the all the kind words! I appreciate it!

You are very welcome! I added a pull request and also added in the tax rate callbacks as I noticed they were missing and may have need of them soon as well