Fix deprecation warnings + Fix autoload warning

tansengming / stripe-rails

A Rails Engine for integrating with Stripe

MIT License

753 stars 123 forks source link

Fix deprecation warnings + Fix autoload warning #220

Closed smtlaissezfaire closed 1 year ago

smtlaissezfaire commented 1 year ago

Fix some warnings when running test suite
Fix issue found in https://github.com/tansengming/stripe-rails/pull/217 (DEPRECATION WARNING: Initialization autoloaded the constant Stripe::JavascriptHelper.)

chrisyuska commented 1 year ago

I've been banging my head against with wall with the issue described in #168 and #217 until I came across this PR. I can confirm this change resolves the issue for me.

tansengming commented 1 year ago

Looks legit based on https://bill.harding.blog/2021/07/22/rails-6-1-deprecation-warning-initialization-autoloaded-the-constants-what-to-do-about-it/

thanks for figuring this out @smtlaissezfaire !