tantaman / strut

Strut - An Impress.js and Bespoke.js Presentation Editor
http://strut.io
GNU Affero General Public License v3.0
1.82k stars 486 forks source link

Slide positions in Overview are not accurately converted to actual positions in impress #240

Closed dlee closed 11 years ago

dlee commented 11 years ago

Here's an example that you can use to reproduce the problem:

{
  "slides": [
    {
      "components": [],
      "z": 0,
      "impScale": 3,
      "rotateX": 0,
      "rotateY": 0,
      "rotateZ": 0,
      "index": 0,
      "selected": false,
      "active": false,
      "background": "bg-solid-black",
      "x": 30,
      "y": 80
    },
    {
      "components": [],
      "z": 0,
      "impScale": 3,
      "rotateX": 0,
      "rotateY": 0,
      "rotateZ": 0,
      "index": 1,
      "selected": false,
      "active": false,
      "background": "bg-solid-orange",
      "x": 260,
      "y": 80
    },
    {
      "components": [],
      "z": 0,
      "impScale": 5,
      "rotateX": 0,
      "rotateY": 0,
      "rotateZ": 0,
      "index": 2,
      "selected": false,
      "active": false,
      "background": "bg-solid-sky",
      "x": 480,
      "y": 80
    },
    {
      "components": [],
      "z": 0,
      "impScale": 1,
      "rotateX": 0,
      "rotateY": 0,
      "rotateZ": 0,
      "index": 3,
      "selected": false,
      "active": true,
      "background": "bg-solid-lavender",
      "x": 780,
      "y": 335
    }
  ],
  "activeSlide": {
    "components": [],
    "z": 0,
    "impScale": 1,
    "rotateX": 0,
    "rotateY": 0,
    "rotateZ": 0,
    "index": 3,
    "selected": false,
    "active": true,
    "background": "bg-solid-lavender",
    "x": 780,
    "y": 335
  },
  "fileName": "presentation-3",
  "deckVersion": "1.0",
  "customBackgrounds": {
    "bgs": []
  },
  "overviewX": 405,
  "overviewY": 207.5
}
thePanz commented 11 years ago

The issue is shown also in latest GIT commit (ea9be4aac28d19174d7576f2d0dd20fe470f7b9e) My test case is here: http://pastebin.com/dYc1YrFk

tantaman commented 11 years ago

This should be fixed now. The overview mode now accurately reflects what is displayed in impress.

thePanz commented 11 years ago

My test case works perfectly! Tested also dlee exampe and works. The only issue is that all the previously saved slides must be replaced, first slide partially appears "out of screen" on the left side.

tantaman commented 11 years ago

Yeah.. I'm not sure there is any way to really fix that but it won't be an issue for any new presentations.

On Fri, Oct 4, 2013 at 11:27 AM, Panz notifications@github.com wrote:

My test case works perfectly! Tested also dlee exampe and works. The only issue is that all the previously saved slides must be replaced, first slide partially appears "out of screen" on the left side.

— Reply to this email directly or view it on GitHubhttps://github.com/tantaman/Strut/issues/240#issuecomment-25707252 .