search

tantek / post-type-discovery

Post Type Discovery editor's draft
https://ptd.spec.indieweb.org/
Creative Commons Zero v1.0 Universal
7 stars 4 forks source link

Present algoritm with elif or as return value? #3

Closed kevinmarks closed 6 years ago

kevinmarks commented 8 years ago

the if nesting is a little unclear as you have to remember the "following these steps until reaching the first "it is a(n) ... post" statement at which point the "..." is the discovered post type."

It may be clearer with an elif structure or a return

tantek commented 8 years ago

I'm going to consider this as editorial rather than substantial, yet keep it open as a reminder to re-assess / iterate on the readability/understandability of the algorithm.

tantek commented 7 years ago

Update: have decided to output (return) a list of post types, including a primary post type, so this issue is likely to no longer apply after rewriting the algorithm accordingly.

I'd like to close this issue without changes accordingly.

kevinmarks commented 7 years ago

Makes sense - that is a better answer for composite posts too.

On 22 Nov 2016 10:45 am, "Tantek Çelik" notifications@github.com wrote:

Update: have decided to output (return) a list of post types, including a primary post type, so this issue is likely to no longer apply after rewriting the algorithm accordingly.

I'd like to close this issue without changes accordingly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

tantek commented 6 years ago

Closing per "Makes sense" agreement from commenter.