search

tanutapi / dart_meteor

A Meteor DDP library for Dart/Flutter developers.
Other
37 stars 15 forks source link

feat: current log-in status instead of progress #20

Closed lekaha closed 3 years ago

lekaha commented 3 years ago

Hi @tanutapi ,

Happy year! Sending this PR that can have way to fetch/track the current log-in status rather than just see if it is in-progress. I am not really sure your original intention of the usage but additionally to know currently it is logged-out or logged-in might be a good idea. Please feel free to merge or close this PR.

tanutapi commented 3 years ago

Happy new year @lekaha!

Thank for your PR submitting. It is a good idea to have such logged-out or logged-in status. However, in the main Meteor document (https://docs.meteor.com/api/accounts.html#Meteor-loggingIn), the Meteor.loggingIn() should return the boolean that indicated the logging-in is currently in progress. I don't want to brake this compatible. However, you may make a new function and name it to something like Meteor.loginStatus() and resubmit the PR again.

Best regards, Tanut

lekaha commented 3 years ago

@tanutapi You are right. Totally forgot to follow the api of Meteor. Will update soon. Thanks.