search

tanveersingh10 / pe

0 stars 0 forks source link

inconsistency in case-sensitivity #10

Open tanveersingh10 opened 7 months ago

tanveersingh10 commented 7 months ago

In add command: Apple and apple are considered 2 separate companies

in find command: if I enter "find /n apple" both companies will show up.

soc-se-bot commented 7 months ago

Team's Response

The implementation for find is completely intended and hence not a functionality bug.

We would like to argue that this is a feature flaw as:

In add command: Apple and apple are considered 2 separate companies

It does fall under duplicate detection, which is under feature flaws (https://nus-cs2103-ay2324s1.github.io/website/admin/tp-pe.html#feature-flaws-2) We will hence reject this, as we already have a planned enhancement for this specific feature flaw:

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Having case sensitivity in person, company and internship names might not be necessary

image.png

Application currently checks for duplicate names. This check, however, is case sensitive. We are able to add the same name with different casing. find already does case-insensitive searching. It might be fairer to assume that "John Doe" and "JOHN DOE" are equivalent, and hence be counted as duplicates.

Similarly, this case insensitivity could also apply to company and internship names as well.

[original: nus-cs2103-AY2324S1/pe-interim#1480] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks,

but this is in planned enhancements.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: It's not a duplicate. What I am raising is the fact that the team is inconsistent about when to be case sensitive and when to be case insensitive.

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I think its confusing for the user if some commands are case sensitive and some are not. I feel like writing it in the UG doesn't mean it's not a mistake. This isn't really a new feature that they want to add in the future.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]