tanveersingh10 / pe

0 stars 0 forks source link

Interviews at the same time #11

Open tanveersingh10 opened 7 months ago

tanveersingh10 commented 7 months ago

In the user guide, it says "SCHEDULED_INTERVIEW_TIME can only be used once"

However, I was able to add 2 separare interviews at the same time as shown in the screenshot Screenshot 2023-11-17 at 4.53.57 PM.png

nus-se-bot commented 7 months ago

Team's Response

Thank you for your feedback!

However, we think that you understood it wrongly. By "SCHEDULED_INTERVIEW_TIME can only be used once", we mean that in a command, you can only use one of s/.

So add i 3 n/Marketing Intern 2024 d/Conduct market research and analysis s/20-02-2024 09:45 is valid,\ but add i 3 n/Marketing Intern 2024 d/Conduct market research and analysis s/20-02-2024 09:45 s/20-02-2023 09:45 is not.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, the sentence that scheduled_interview_time can only be used once sentence is unclear. I think its quite intuitive for a user to interpret it as u cant have 2 interviews at the same time.

Secondly, even if I'm wrong about the meaning of the sentence, I still think it's a bug to be able to have 2 interviews at the same time.


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** I think its a bug in the code if you can put 2 interviews at the same time on the same date. One example is that it's possible a user put an interview at apple for lets say 2pm and called it "interview with apple". then he forgot he already put it in and re entered "apple interview" at 2pm on the exact same date. That's a duplicate I believe. A user may also just have 2 conflicting interviews which shouldn't be allowed.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]