tanveersingh10 / pe

0 stars 0 forks source link

Incorrect Use Case in DG #13

Open tanveersingh10 opened 7 months ago

tanveersingh10 commented 7 months ago

Screenshot 2023-11-17 at 5.18.49 PM.png

After the internship doesn't exist and the error is throw, the use case should end. the Dg says it continues from step 1 which seems like an infinite loop

nus-pe-script commented 7 months ago

Team's Response

Thank you for raising this.

The phrase "resumes from step 1" in the use case doesn't imply an automatic loop. It means that after an error, the user is given the chance to start over, not that the system automatically retries the action.

The use case correctly handles errors by informing the user and allowing them to choose whether to retry or stop. This is a standard practice in user interface design and is in line with our implementation.

An infinite loop would occur if the system repeated an action without user intervention. Here, the process only continues if the user decides to retry, thus avoiding any automatic, endless repetition. Ending the use case after an error without allowing the user to retry would be less user-friendly and practical. The current design appropriately balances error handling with user control.

We believe that current language in Use cases are right but acknowledge that it may be confusing for some readers. Thus, we decided to downgrade the severity to low without rejecting this.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]