search

tanveersingh10 / pe

0 stars 0 forks source link

Duplicate person #2

Open tanveersingh10 opened 7 months ago

tanveersingh10 commented 7 months ago

I added John Doe to the app When I try to add John Doe again, it says the person already exists However, when I change it to john doe (lowercase) the add command works

i think this is a bug because it's quite likely that it's the same person all the other fields are the exact same also

nus-se-bot commented 7 months ago

Team's Response

Thanks for bringing this to our attention!

We would like to move this under feature flaws, as bugs related to duplicate detection fall under feature flaws.

In addition, we also listed "Capitalisation Checking of Duplicate Contact for add Command" under planned enhancements, hence sorry we will have to reject :(

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Having case sensitivity in person, company and internship names might not be necessary

image.png

Application currently checks for duplicate names. This check, however, is case sensitive. We are able to add the same name with different casing. find already does case-insensitive searching. It might be fairer to assume that "John Doe" and "JOHN DOE" are equivalent, and hence be counted as duplicates.

Similarly, this case insensitivity could also apply to company and internship names as well.

[original: nus-cs2103-AY2324S1/pe-interim#1480] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks,

but this is in planned enhancements.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I believe putting it in the user guide doesn't change the fact that it's a bug. It's clear the team intended to prevent duplicate names, and that behaviour is not working as expected. If i have fast typing speed it's possible i might miss out a capitalisation. I think the team should take responsibility for a small oversight rather than trying to use the user guide to cover it up. I'm willing to accept its severity low instead of medium.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** As mentioned, the team was clearly trying to prevent duplicate names. However, they did not do so correctly, as its quite possible someone with fast typing speed might miss a capitalization.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]