search

tanveersingh10 / pe

0 stars 0 forks source link

Duplicate companies #5

Open tanveersingh10 opened 7 months ago

tanveersingh10 commented 7 months ago

First I added the company Apple to the app

If i try to add Apple again it says it already exists If I change it to apple it works

it's quite possible a user may forget to capitalize. Especially since app is for users with fast typing speed.

nus-se-script commented 7 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Can add duplicate companies

Companies, while are case-sensitive, should not have the same spelling due to copyright issues. This can ause issues for applicants accidentally add multiple entries of the same company, and thus get the wrong info if they saved the info in one entry, and forget the other.

image.png

[original: nus-cs2103-AY2324S1/pe-interim#1405] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for bringing this to our attention!

We would like to move this under feature flaws, as bugs related to duplicate detection fall under feature flaws.

In addition, we also listed "Capitalisation Checking of Duplicate Contact for add Command" under planned enhancements, hence sorry we will have to reject :(

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Just putting it under planned enhancements doesn't change the fact that it's a mistake. Your intention was to prevent duplicates, which is not working as expected due to an oversight.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** They wanted to prevent duplicates but didn't implement it correctly. Hence its a functionality bug.