search

tanveersingh10 / pe

0 stars 0 forks source link

Add internship for 30th February #8

Open tanveersingh10 opened 7 months ago

tanveersingh10 commented 7 months ago

I added an internship for 30th February 2024 which doesn't exist. The app doesnt throw an error and adds an internship for 29 February 2024.

No check implemented for valid date.

Put as low because mentioned already in UG

nus-pe-bot commented 7 months ago

Team's Response

Thank you for raising this issue!

However, this is not a functionality bug this functionality does work as specified in the UG. We do agree that this may be a feature flaw though.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid date can be input

image.png

When I input 29-02-2023 12:21 as the date and time for the interview, there is no error thrown even though this is an invalid date. Instead, the date is saved as 28 Feb with no further prompts or messages. This could cause someone to unknowingly save the completely wrong date for the internship. However, such an error only arises occasionally and the product can still be used, hence it is not of high severity.

[original: nus-cs2103-AY2324S1/pe-interim#3724] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you!

We believe that this is not a functionality bug but instead a feature flaw, as we do state in our UG:

image.png

However, we do agree that it is something we should throw an error/warning for.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]