tanweien / pe

0 stars 0 forks source link

Possible to add new contact without any contact details #8

Open tanweien opened 2 years ago

tanweien commented 2 years ago

New contacts are created using the n/ command, then are edited after creation. This may allow the creation of redundant contacts (ie contacts without any compulsory fields) which may be considered a feature flaw.

Screenshot 2022-04-16 at 2.49.42 PM.png

nus-se-script commented 2 years ago

Team's Response

A contact requires one compulsory field, which is the name. It is not beneficial to the user to restrict them to having to provide more fields. It is possible that a user wants only to add a contact's name, and then enter their fields at a later time. If the user chooses to use the product in this manner, it does not behoove the developer to prevent them from doing so.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that contacts without any other fields can be considered a feature flaw. As per module guidelines, having a name without any fields may complicate things for the user and does not solve the stated problem of the intended user. Maybe one suggestion could be to make some fields such as phone numbers compulsory such that each contact has some meaning attached to them.

Screenshot 2022-04-20 at 8.26.55 PM.png