search

tanweien / pe

0 stars 0 forks source link

Possible to add new contacts with names that may not make sense #9

Open tanweien opened 2 years ago

tanweien commented 2 years ago

New contacts can be created, even if the names might not make sense. (eg ".", "---.-")

Steps to recreate: the command "add n/." will add a new contact with the name ".", which does not make sense.

Screenshot 2022-04-16 at 2.52.52 PM.png

nus-se-bot commented 2 years ago

Team's Response

It does not benefit the user to police what they can or cannot name their contacts to such an extent. If the user wishes to name a contact with special characters to suit their use, they should be permitted to do that. Moreover, the user likely does not have any expectation that this validation would exist seeing as almost all common contacts apps on the market allow for this type of naming.

As per the module site:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As per the screenshot above, no warnings are provided when users key in inputs that do not make logical sense.

Following the reasoning given, numeric characters in names should be allowed as well, which is generally considered a bug.