search

tanyapowell / restaurant-reviews

Side project for the Black CodHer bootcamp. All contributions are welcome ♥️
https://restaurant-reviews.vercel.app
2 stars 0 forks source link

Pull Request template #13

Closed AffirmedVisionary closed 3 years ago

AffirmedVisionary commented 4 years ago

Not sure what else needs to be added. thinking it is one of those that will get more detailed as we go along maybe.

it is funny because I am not using the template right now and I am lost at what to write lol so it is definitely going to do its job.

fixes issue #3

@tanyapowell can you jump on the reviewing of this too, just to make sure it has what is needed.

ps. the display rich diff button makes a real difference so try it out when reviewing the code

image

emma-mendez commented 4 years ago

The tick options sorry? Is the idea to tick them when using the template in the doc/PULL... and also for when reading the guidelines - or use the info from the template or signpost to the doc/PULL.. what do you think? If so I currently can’t tick the boxes- so to make sure contributors can, are you able to tick inside the boxes?

On Sun, 8 Nov 2020 at 13:28, Charlene Grant notifications@github.com wrote:

@AffirmedVisionary commented on this pull request.

In docs/PULL_REQUEST_TEMPLATE.md https://github.com/tanyapowell/restaurant-reviews/pull/13#discussion_r519399022 :

+## Type of change

+

+:question: Please tick all relevant options

+

+- [ ] Bug fix (non-breaking change which fixes an issue)

+- [ ] New feature (non-breaking change which adds functionality)

+- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

+- [ ] This change requires a documentation update

Yes of course would love to look at this further - @AffirmedVisionary https://github.com/AffirmedVisionary let’s work - let me know when you are free and I’ll meet you the same time to bang it out? But mainly to make sure users can utilise the buttons in the way you vision because I’m unsure myself how to best use it where it clicks

Which buttons?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tanyapowell/restaurant-reviews/pull/13#discussion_r519399022, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQQA5MVPGXNOTLOE446HTUTSO2MGTANCNFSM4TN4NJZA .

AffirmedVisionary commented 4 years ago

The tick options sorry? Is the idea to tick them when using the template in the doc/PULL... and also for when reading the guidelines - or use the info from the template or signpost to the doc/PULL.. what do you think? If so I currently can’t tick the boxes- so to make sure contributors can, are you able to tick inside the boxes?

So to my understanding, the way the templates work is after this is approved and I have merged it to the main branch.

Every time one of us create a pull request, this template will appear in the Write/Comment/Description section. We would then on our own go through and add to or edit each section with a ❓ next to it. if the boxes are not tickable, placing an x inside the square bracket works. you can check this in preview mode. <-- you can add this to the guidelines.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tpowell/restaurant-reviews/85a801ncn
✅ Preview: https://restaurant-reviews-git-pulltemplate.tpowell.vercel.app

AffirmedVisionary commented 3 years ago

I know, I have serious OCD but you did say you were haunted without code @AffirmedVisionary lol....

lol all done x