nus-pe-script
commented
2 years ago Team's Response
Duplicate of #3429. Both are issues with invalid dates and there being a wrong error message. Changing the message for the invalid date will solve both issues.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Incorrect error messsage for invalid date entered for borrow command
Description:
Enter an invalid date such as 30-Feb-2023.
Step to reproduce: borrow 1 1 30-Feb-2023
Expected: Error message stating invalid date entered.
Actual: Error message stating invalid command format.
[original: nus-cs2103-AY2122S2/pe-interim#3500] [original labels: severity.Low type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for pointing out the bug. As per module website, inaccuracy of error messages should be feature flaw, hence converting this into feature flaw.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue type
Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
When invalid date (31 Apr) is put in, the warning is confusing as it indicates that an invalid format has been keyed in, when really the issue is with the date being an impossible one.