Closed tanzislam closed 6 years ago
The SonarCloud plugin is documented to not work on external pull requests, but it's worse than just that -- the plugin's utility scripts are actually not present during the run, causing a build failure on the pull request. (Example: https://github.com/tanzislam/cryptopals/pull/17.) Need to revert to a normal build during external pull requests (or perhaps all pull requests, if simpler), until the promised feature of scanning external pull requests appears.
On another note, the github_token property in .travis.yml is now deprecated. It was used for supplying the personal access token of the GitHub account to use for annotating internal pull requests, and can now be specified in
github_token
.travis.yml
the “Administration > General Settings > Pull Requests” page of your project on SonarCloud
So need to remove that key and its documentation from the .travis.yml file, and the SONAR_GITHUB_TOKEN encrypted environment variable from Travis settings.
SONAR_GITHUB_TOKEN
The SonarCloud plugin is documented to not work on external pull requests, but it's worse than just that -- the plugin's utility scripts are actually not present during the run, causing a build failure on the pull request. (Example: https://github.com/tanzislam/cryptopals/pull/17.) Need to revert to a normal build during external pull requests (or perhaps all pull requests, if simpler), until the promised feature of scanning external pull requests appears.
On another note, the
github_tokenproperty in.travis.ymlis now deprecated. It was used for supplying the personal access token of the GitHub account to use for annotating internal pull requests, and can now be specified inSo need to remove that key and its documentation from the
.travis.ymlfile, and theSONAR_GITHUB_TOKENencrypted environment variable from Travis settings.