All the streambuf-derived classes should be non-copyable

tanzislam / cryptopals

:closed_lock_with_key: My answers to challenges in https://cryptopals.com

GNU General Public License v3.0

8 stars 5 forks source link

All the streambuf-derived classes should be non-copyable #20

Closed tanzislam closed 3 years ago

tanzislam commented 5 years ago

The std::basic_streambuf<> class template has a copy constructor as of C++11 that does a shallow-copy of the member pointers, which is completely unsuitable for our "mechanism" use case. Apply boost::noncopyable to mitigate this.

tanzislam commented 3 years ago

Other C++ issues:

[x] Use the override specifier for derived member functions.
[x] Wrap global/namespace-scope non-trivially-constructible objects into functions.

tanzislam commented 3 years ago

Done in 8a05569a9af191d18dfcea2d46d8aa4be9964856, 1d584d2b581e0d80f8806ccecccf125b125edf59 and 0c4367ec1c7b300f923558d159c7cf9919961467.