search

tanzquotient / website

Website of Tanzquotient
https://tanzquotient.org
GNU General Public License v2.0
5 stars 5 forks source link

assign same adress to multiple Rooms #159

Closed melissazacharias closed 6 years ago

melissazacharias commented 6 years ago

At the moment, two rooms cannot have the same adress. Selecting an adress twice results in an error message. This needs to be changed as we now have multiple rooms in the same building.

renatobellotti commented 6 years ago

The problem is that the Room model in courses/models.py defines the address as a OneToOneField. This should be changed.

Related documentation

gitsimon commented 6 years ago

Yes you could change this, but think about it: if rooms share addresses (link to the same address instance), you will have possibly undesired side effects when you edit one room's address. As the address model is also used by user profiles, I decided to never share addresses between objects at the time of writting that models.

roggnroll commented 6 years ago

can't you add the room number other some other extra information to the address?

renatobellotti commented 6 years ago

I don't think there will be a problem when modifying an address. When would this influence the user addresses? Nobody lives at ETH and/or UZH...

roggnroll commented 6 years ago

Not considered an issue - include room numbers in issue