tanzquotient / website

Website of Tanzquotient
https://tanzquotient.org
GNU General Public License v2.0
5 stars 5 forks source link

Facilitate sorting of outgoing payments #187

Closed annmoser closed 6 years ago

annmoser commented 6 years ago

Add a new "TYPE" on the TQ Website for online payments. Goal is that I can manually mark payments that I have collected in the payment summary as "archived".

annmoser commented 6 years ago

Sorry, Telegram funktioniert bei mir zurzeit nicht. Drum mach ich es so.

Auf der Website bei Online Payments habe ich bei "TYPE" fünf Optionen: "subscription payment", "subscription payment (to reimburse)", "course payment transfer", "irrelevant" und "unknown". Debit Zahlungen, (outgoing money) werden zurzeit als "irrelevant" eingestuft. Ich habe begonnen, für das 2018 die Ausgaben aufzulisten - für Bargeldkasse und für online Zahlungen. In einem Google Form liste ich Ausgaben, Kategorie und Zahlweise auf, zusammen mit dem digitalen Beleg. Jeder Online Zahlung, die ich ins Google Form eingetragen habe, würde ich gerne ein neues "TYPE" zuordnen. So habe ich den besseren Überblick.

renatobellotti commented 6 years ago

Introduce another type "completed"

kadirakin85 commented 6 years ago

Is it OK with this change ? There is also now Archive as a Type for payments.

annmoser commented 6 years ago

I found the "archive" as type for payments, thanks Unfortunately, there is still one bug (necessary) and something I would like to have (nice to have)

I marked a few debit payments as "archive". Suddenly, everything changed back "irrelevant". I pressed the save button everytime. I tried it again and the same thing happened after about 10 payments. It seems like the type "irrelevant" is a default for debit payments and cannot be overwritten (for the moment).

It would be fantastic, if the option "mark debit payments as ARCHIVE" would be in the drop down menu, so that I just can mark all the payments I want and set them to "archive" in one go.

Of course, the first issue is the important one. The second is just nice to have... Thanks!

kadirakin85 commented 6 years ago

tq_archieve

I couldnt regenerate the bug that you mentioned. Somehow for me it works fine as shown in attached figure. Renato, do you have an idea ?

I will check if I can make "archive in one go" option, I will look at that on Saturday.

renatobellotti commented 6 years ago

Which payments would you like to change to ARCHIVE type? (please no names, only payment IDs)

annmoser commented 6 years ago

I need to be able to change type to ARCHIVE myself. If that is not possible, then we can also leave the feature and I can deal with it another way. As example we can take any payments between 4973 and 4986.

renatobellotti commented 6 years ago

@kadirakin85, @annmoser after thinking again about it, it would make more sense to me to add ARCHIVE as an additional STATE, not TYPE. What do you think?

@annmoser I understand that you need to make the changes yourself. That should definitely be possible because you have full admin permissions. If I understood correctly, the TYPE attribute is reset after some time? (Please do not try this now because this would mean to lose data in case we decide to make "archive" a STATE)

renatobellotti commented 6 years ago

It came to my mind what is wrong: We forgot to make and perform the database migration, so the database does not "know" about the new TYPE.

kadirakin85 commented 6 years ago

@renatobellotti Is there a wiki page about how to do database migration ? Or should we do it together ? We can meet on Monday if it is possible for you too.

renatobellotti commented 6 years ago

It should be working for good now. The button is still under construction. :)

kadirakin85 commented 6 years ago

Now we have a new function called "Archive selected Payments" to allow one go action. Archive is now a state, but not a type.

kadirakin85 commented 6 years ago

And the new function will be working after Renato updates the server.

renatobellotti commented 6 years ago

The changes should now be online. Thanks again for taking your time and motivation! :)

annmoser commented 6 years ago

Thanks for all the work! Now it also works for me as hoped, also as non-administrator. I'd consider this chapter closed :)