tao-software / tao-schedule-update

Wordpress Plugin to Schedule Content Updates
https://wordpress.org/plugins/tao-schedule-update/
MIT License
16 stars 14 forks source link

Fixes for issue #1. #2

Closed ollietreend closed 8 years ago

ollietreend commented 9 years ago
Syberspace commented 9 years ago

Correct me if I'm wrong, but is there any case in core wordpress where transition_post_status triggers with both $old and $new being the same? Isn't the sole reason for this hook to capture a change in post status?

ollietreend commented 9 years ago

I believe it is possible for the old and new status to be the same.

According to the docblock for the wp_transition_post_status function:

When a post is saved, the post status is "transitioned" from one status to another, though this does not always mean the status has actually changed before and after the save.

ollietreend commented 9 years ago

@Syberspace Have you had any further thoughts on this?

I'm already using my forked version of this plugin on one website, and it's working nicely. However I'd much rather be using the 'real' plugin via the official WordPress plugin repository.

Do you have any further questions about this PR, or can it be merged in?

Syberspace commented 9 years ago

Thanks for your efforts in getting this thing cleaned up. Didn't really have time to check out your code yet. To be honest, this plugin is just a little side project here at TAO Software and if the schedule is tight we don't really give it much attention. I'm pretty sure we'll integrate some hooks in one of the next releases. Though I don't know when this release might be

ollietreend commented 9 years ago

Thanks @Syberspace. I appreciate that time is often a sparse resource. It's no problem – I'll keep using my own fork of this plugin for now.